fix(iam): referencing the same immutable role twice makes it mutable#20497
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Jun 1, 2022
corymhall:corymhall/aws-iam/fix-fromrolearn
Merged
fix(iam): referencing the same immutable role twice makes it mutable#20497mergify[bot] merged 2 commits intoaws:masterfrom corymhall:corymhall/aws-iam/fix-fromrolearn
mergify[bot] merged 2 commits intoaws:masterfrom
corymhall:corymhall/aws-iam/fix-fromrolearn
Conversation
The solution I went with in this PR was to try and keep the provided id set on the `ImmutableRole` instead of the `Import` role. This should also keep backwards compatibility by only changing the id of the `Import` role if we are returning an `ImmutableRole`. fixes #7255
|
|
github-actions
bot
added
bug
rix0rrr
changed the title
rix0rrr
changed the title
rix0rrr
approved these changes
Jun 1, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution I went with in this PR was to try and keep the provided id
set on the
ImmutableRoleinstead of theImportrole. This shouldalso keep backwards compatibility by only changing the id of the
Importrole if we are returning anImmutableRole.fixes #7255
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license